Skip to content

Conversation

@lwizchz
Copy link
Contributor

@lwizchz lwizchz commented May 1, 2014

I originally started this for personal use but it garnered support from the linux chan so I decided to continue working on it.

Sorry for the large commits but it's intended to be an (almost) drop-in replacement for the QT interface.

This is a purely functional pull request and should include most major functionality. Over the next few weeks, I'll add more comments, fix bugs, and introduce features which I may have overlooked.

I've never contributed to this project before, so please correct any errors or conventions I need to fix.

The Inbox tab:
screenshot from 2014-04-30 20 34 53
The Network Status tab:
screenshot from 2014-04-30 20 35 39

lwizchz added 11 commits April 18, 2014 00:48
+ Add stderr capturing
+ Add identities and network status tabs
+ Add dialogs to configure identities
+ Add color pair definitions
+ Add the '-c' flag to use the curses interface
* Reorganize imports
* Switch logger to file_only mode when running with curses
* Make tables more distinct with horizontal lines
- Remove start_color() because wrapper() does it anyway
+ Add function ascii() to strip non-ASCII characters
+ Add Inbox, Send, and Address Book tabs support
+ Add Home and End key handling to allow skipping to the top or bottom of tables
+ Add sendMessage() function so replies are easier and code is not duplicated
+ Add screen clear before initial draw in order to get rid of the default background color
* Fix resetlookups() by allowing access to global inventorydata
* Shorten resetlookups() Timer to 1 second
* Fix table display when output requires scrolling
* Change table column width from 50 to 30
- Remove conditional naptime by using blocking input with 1 second timeout
- Remove stderr capturing for development purposes
+ Add code to delete address from Your Identities
+ Add code to load Sentbox, Subscriptions, and Blacklist
* Lengthen column width from 30 to 40 to better fit unlabeled addresses and long subject lines
* Fix row overflow support
* Reorder Dialog initialization to remove duplicate code
* Add reply argument to sendMessage()
* Add newline to Move to Trash message
* Replace Your Identities address copy option with an option to send a message
* Move global variable declaration to prevent warnings
* Fix Address Book and Subscriptions entry prepending
* Fix shared.fixPotentiallyInvalidUTF8Data() corrupting sent subjects and message bodies
@Atheros1
Copy link
Contributor

Atheros1 commented May 1, 2014

Interesting. ...

@ghost
Copy link

ghost commented May 23, 2014

Looks nice. Would be useful on a server.

@lwizchz
Copy link
Contributor Author

lwizchz commented May 25, 2014

Thanks. By the way, I apologize for the recent lack of progress, I've
gotten bogged down by finals. In a few weeks I'll have plenty of time to
continue development.

@themighty1
Copy link

@piluke
Thank you for your work on the cli interface.
My experience shows that it is best to maintain extra features like these in one's own repo. You can simply query BM via API calls. If this gets merged into the main BM repo, then every time you needed to add a fix, you'd be creating a new pull request which had to be reviewed by some other dev. This would be rather cumbersome.

@ghost
Copy link

ghost commented Jun 7, 2014

"every time you needed to add a fix, you'd be creating a new pull request which had to be reviewed by some other dev"

Isn't that the case for every project on Github anyway?

Atheros1 added a commit that referenced this pull request Jul 14, 2014
Add a curses terminal interface as an alternative to QT
@Atheros1 Atheros1 merged commit e3124e1 into Bitmessage:master Jul 14, 2014
@rubensayshi
Copy link
Contributor

awesome work, but it's not very stable and it doesn't really work with the the python-dialog package on ubuntu, you need to specifically install python2-pythondialog with pip.

Very nice start, also considering it makes it easier to debug stuff when you're running bitmessage on a server as daemon, but needs to polishing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants