Fix test timeout by disabling IPFS/Nostr in test mode#59
Merged
Conversation
- Force IPFS offline mode when TFP_DB_PATH=:memory: to prevent network calls during tests - Disable Nostr subscribers/bridges when TFP_DB_PATH=:memory: to prevent network calls during tests - This fixes tests/test_grand_completion.py::TestContentPagination::test_limit_restricts_results timeout at 30s - Unit tests should be deterministic and fast without external network dependencies
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Apply ruff formatting to tfp_demo/server.py - Allow Nostr bridge initialization in test mode but force offline to prevent network calls - Update test_feature_flags.py to expect offline mode in test mode - Add CI_ISSUES_STRATEGY.md with comprehensive prevention strategy Fixes failures in: - Job 71956360032 (ruff format) - Job 71956385838 (test_feature_flags.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the change.
Type of Change
Testing
TFP_DB_PATH=:memory: PYTHONPATH=. pytest tests/ -qChecklist
ruff check .passes)git commit -s)Related Issues
Fixes #(issue number)
Additional Notes
Any special deployment notes, breaking changes, or follow-up tasks?