Default image added for articles without images #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for putting in the work on this one. One thing that I would suggest in the PR description is a reminder that folks may read the PR description with little to no knowledge of how we got to a decision. I'm happy to approve this but it would be great in the future that we add more information to our descriptions that will help with that part. |
kjaymiller
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Issue: #533
Type of Change
Description 📋
What: Added a default image to be displayed for articles without a custom image.
Why: To maintain the design and user experience of our website
How: The default image is stored in the assets folder and automatically displayed when an article lacks a specified image.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.