Skip to content

⚡ Optimize GenerateTopologyHash allocations#10

Merged
xkilldash9x merged 1 commit intomainfrom
perf/optimize-hash-gen-515067491780145595
Feb 4, 2026
Merged

⚡ Optimize GenerateTopologyHash allocations#10
xkilldash9x merged 1 commit intomainfrom
perf/optimize-hash-gen-515067491780145595

Conversation

@xkilldash9x
Copy link
Copy Markdown
Collaborator

💡 What:
Optimized GenerateTopologyHash in pkg/detection/engine.go by:

  1. Pre-allocating the calls slice to avoid resizing.
  2. Replacing strings.Builder and strconv.Itoa inside the loop with a reusable []byte buffer and strconv.AppendInt.

🎯 Why:
The previous implementation allocated a new strings.Builder (and underlying buffer) and multiple strings (via Itoa) for every call signature in the loop. This created significant memory pressure and GC overhead in hot paths.

📊 Measured Improvement:
Benchmark BenchmarkGenerateTopologyHash results:

  • Time: ~23% faster (35031 ns/op -> 27030 ns/op)
  • Allocations: ~50% reduction (215 allocs/op -> 108 allocs/op)
  • Memory: ~28% reduction (12328 B/op -> 8856 B/op)

PR created automatically by Jules for task 515067491780145595 started by @xkilldash9x

- Pre-allocate `calls` slice to avoid resizing.
- Replace `strings.Builder` loop with reusable `[]byte` buffer and `strconv.AppendInt`.
- Reduces allocations by ~50% and execution time by ~23%.

Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@xkilldash9x xkilldash9x merged commit 45bb265 into main Feb 4, 2026
1 of 2 checks passed
@xkilldash9x xkilldash9x deleted the perf/optimize-hash-gen-515067491780145595 branch February 4, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant