parity(ses): fix all parity.md findings#2359
Merged
Merged
Conversation
…ability - Handler.StartWorker: track janitor goroutine with cancel+done channel (was fire-and-forget) - Handler.Shutdown: new method joins janitor goroutine; implements service.Shutdowner - Compile assertions: var _ service.BackgroundWorker/Shutdowner = (*Handler)(nil) - InMemoryBackend: add region/accountID fields initialized to config defaults - WithRegion/WithAccountID: functional options for per-instance configuration - Region()/AccountID(): return stored fields instead of hardcoded constants - Error messages: "failed the check in region %s" uses strings.ToUpper(b.region) instead of hardcoded "US-EAST-1" - backendSnapshot: persist region/accountID; Restore applies them with fallback - parity_b_test.go: table tests for Shutdowner, idempotent StartWorker, GetSendQuota tracking, WithRegion/WithAccountID, region in error messages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Executed-By: gopherstack/polecats/amber
Collaborator
Author
📊 Code Coverage Report
Tip This project maintains a minimum coverage threshold of 85%. Maintain or improve coverage on new code to ensure long-term stability. Last updated: Thu, 25 Jun 2026 12:02:29 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SES (Classic) parity. Validated unit + scoped integration. GH006-safe PR.
🤖 Generated with Claude Code