Merged
Conversation
Introduces a new ViewController with endpoints for fetching single views, batch views, and views by channel. Adds related request, response, and mapper classes for view operations. Also fixes a typo in ViewsInChannelUseCase by renaming 'viewIds' to 'viewsIds'.
Corrected a typo in the ViewController endpoint from '/views/batch-betch' to '/views/batch-fetch'. Added the @Mapper annotation with 'spring' component model to ViewsInChannelMapper for proper MapStruct integration.
Updated the /views/batch-fetch endpoint in ViewController from GET to POST to properly handle request bodies for batch fetching views.
NikodemCyrzan
previously approved these changes
Dec 29, 2025
All mapper implementations now extend their respective domain Mapper interfaces (e.g., ChannelMapper, ProjectMapper, TaskMapper, etc.) for consistency and potential shared logic. Additionally, TaskCreateRequest and TaskPatchRequest fields 'beginAtTimestamp' and 'endAtTimestamp' are renamed to 'beginAt' and 'endAt' to standardize naming.
Collaborator
Author
|
Sorki, zauważyłem problem dosyć spory ze wszystkimi mapperami XD, musiałem to wrzucić tutaj |
NikodemCyrzan
approved these changes
Dec 29, 2025
scraft-official
added a commit
that referenced
this pull request
Jan 4, 2026
* Add view management API endpoints and mappers Introduces a new ViewController with endpoints for fetching single views, batch views, and views by channel. Adds related request, response, and mapper classes for view operations. Also fixes a typo in ViewsInChannelUseCase by renaming 'viewIds' to 'viewsIds'. * Fix typo in endpoint and add MapStruct annotation Corrected a typo in the ViewController endpoint from '/views/batch-betch' to '/views/batch-fetch'. Added the @Mapper annotation with 'spring' component model to ViewsInChannelMapper for proper MapStruct integration. * Change batch fetch endpoint to POST method Updated the /views/batch-fetch endpoint in ViewController from GET to POST to properly handle request bodies for batch fetching views. * Unify mapper interfaces and update task request fields All mapper implementations now extend their respective domain Mapper interfaces (e.g., ChannelMapper, ProjectMapper, TaskMapper, etc.) for consistency and potential shared logic. Additionally, TaskCreateRequest and TaskPatchRequest fields 'beginAtTimestamp' and 'endAtTimestamp' are renamed to 'beginAt' and 'endAt' to standardize naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Views" API to the backend, enabling fetching of individual views, batch fetching by IDs, and retrieving all views for a specific channel. It adds the necessary controller, request/response DTOs, and mappers for the new endpoints, and also updates the tasks API to support fetching tasks by channel. Additionally, it fixes a naming inconsistency in the
ViewsInChannelUseCaseresult.New "Views" API Implementation:
ViewControllerwith endpoints to fetch a single view, batch fetch views by IDs, and fetch all views for a channel, including OpenAPI documentation and organization header support.ViewsBatchFetchRequest,ViewResponse,ViewsBatchFetchResponse,ViewsListResponse, andViewResponseContent. [1] [2] [3] [4] [5]ViewMapper,ViewFetchMapper,ViewsBatchFetchMapper, andViewsInChannelMapper. [1] [2] [3] [4]ViewResponseContentMapping).Enhancements to Existing APIs:
TaskControllerfor fetching tasks by channel, with OpenAPI documentation and organization header.TasksBatchFetchRequestfor compatibility with frameworks.Bug Fixes / Consistency:
ViewsInChannelUseCase.Resultby renamingviewIdstoviewsIdsthroughout the codebase. [1] [2]