Skip to content

Fix code scanning alert no. 1: Clear-text logging of sensitive information#5

Merged
Vigneshkna merged 1 commit into
develop/packagefrom
autofix/alert-1-95447cac99
Sep 27, 2024
Merged

Fix code scanning alert no. 1: Clear-text logging of sensitive information#5
Vigneshkna merged 1 commit into
develop/packagefrom
autofix/alert-1-95447cac99

Conversation

@Vigneshkna
Copy link
Copy Markdown
Contributor

Fixes https://github.com/Blackplums/how2validate/security/code-scanning/1

To fix the problem, we should avoid logging any part of the secret, even in a redacted form. Instead, we can log a generic message indicating that a secret is being validated without including the actual secret value. This approach ensures that no sensitive information is exposed in the logs.

  • Modify the logging statement on line 85 in src/python/how2validate/validator.py to remove the secret from the log message.
  • Ensure that the log message still provides useful information without exposing sensitive data.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…ation

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Vigneshkna Vigneshkna added the security fix security related fixes label Sep 27, 2024
@Vigneshkna Vigneshkna self-assigned this Sep 27, 2024
@Vigneshkna Vigneshkna marked this pull request as ready for review September 27, 2024 11:34
@Vigneshkna Vigneshkna merged commit 10ccc16 into develop/package Sep 27, 2024
@Vigneshkna Vigneshkna deleted the autofix/alert-1-95447cac99 branch September 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security fix security related fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant