DDR4 SPD detection fails when SPD byte 0 = 0x24

[a1ive]

I installed 4× DDR4 DIMMs, but it only detects two of them.
Here is the output log: Log.txt

After checking the SPD dumps, I noticed that the undetected DDR4 modules have SPD byte 0 = 0x24, while the detected ones use 0x23.

According to the current implementation in DDR4Accessor.IsAvailable, the function returns true only when:

RAMSPDToolkit/RAMSPDToolkit/SPD/DDR4Accessor.cs

Lines 143 to 144 in e2f4205

	//DDR4 is available if value is 0x23
	return value == 0x23;

When I modify the code as follows, all 4 DDR4 DIMMs are detected correctly.

return (value == 0x23) || (value == 0x24);

Here is the log after applying this change: Log.txt

[Blacktempel]

Thank you for the detailed report and your logs.
I will check the logs in depth later today.

It does seem the detection for DDR4 can be improved as it does seem to be a bit fragile.
I'll check and test with my old DDR4 system if we can just read byte 0x02 (Key Byte / DRAM Device Type) instead of 0x00 (Number of Bytes Used / Number of Bytes in SPD Device) and check the actual identifier.
Maybe there's another way it can be detected more accurately - to have some kind of fallback, will have to re-check the standard later when I have more time.

[Blacktempel]

Please re-check with changes I just pushed.

[a1ive]

Please re-check with changes I just pushed.

It works now. All four DIMMs are detected correctly.
Thank you.

[Blacktempel]

Will be released with next version.