Fix APK build: self-contained Kotlin-DSL Gradle project#2
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI failed with
Your app is using an unsupported Gradle project. Root cause: the repo committed legacy Groovy Gradle files (build.gradle,settings.gradle, wrapper 8.x), while the CI stepflutter create . --platforms=androidregenerated modern Kotlin-DSL files (AGP 9.x / Gradle 9.x) on top of them — producing an inconsistent, half-migrated Android project on every run.This PR makes the Android project self-contained and deterministic so
flutter build apk --release --no-pubsucceeds withoutflutter create:settings.gradle.kts,build.gradle.kts,app/build.gradle.kts) consistent with Gradle9.1.0+ AGP, and updategradle-wrapper.propertiesto match.gradlew(now gitignored);flutter buildregenerates them, verified in a clean checkout.flutter create .step from.github/workflows/build_apk.yml; CI now just runsflutter pub getthen builds.Additional fixes required for the build to compile:
app/build.gradle.kts: addimplementation("com.google.android.material:material:1.12.0")—Theme.EclipseShellextendsTheme.MaterialComponents.*, which otherwise fails Android resource linking.AndroidManifest.xml: remove the deprecatedpackageattribute (rejected by AGP 8+; namespace comes from Gradle).lib/audio/audio_handler.dart: remove a duplicate_defaultScanRoot()declaration and add the missingtoggleShuffle()method called fromeclipse_shell_app.dart.Also added a
pull_requesttrigger to the workflow so the APK build is validated on PRs (not only on push tomain), guarding against future regressions.Verification
gradlewpresent, noflutter create):buildcheck passes on this PR.Link to Devin session: https://app.devin.ai/sessions/397387253e524159baa36ad526240957
Requested by: @BlazeTrack