End to end type safety.

[niteshbalusu11]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's robustness and maintainability by implementing end-to-end type safety. It introduces the ts-rs crate to automatically generate TypeScript type definitions from Rust server-side data structures, ensuring seamless type consistency between the backend and frontend. This change centralizes API type definitions, reduces manual synchronization errors, and streamlines development workflows. Additionally, it refactors client-side public key management for improved state handling.

Highlights

• Automated Type Generation with ts-rs: The ts-rs crate has been integrated into the server-side Rust project. This powerful tool automatically generates TypeScript type definitions from Rust structs and enums, ensuring that the client-side and server-side data models remain perfectly synchronized without manual effort.
• Centralized Server API Type Definitions: All API-related data structures on the server have been centralized into a new server/src/types.rs module. This refactoring improves code organization, maintainability, and serves as the single source of truth for type generation.
• Client-Side Adoption of Generated Types: The client-side TypeScript code has been updated to consume these newly generated types from client/src/types/serverTypes.ts. This ensures end-to-end type safety for all API interactions, catching potential type mismatches at compile time rather than runtime.
• Refactored Public Key Management on Client: The management of the staticVtxoPubkey on the client has been refactored. Instead of being set directly during wallet creation, it is now managed via a new usePeakKeyPair React Query hook, improving state management and data fetching patterns.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces end-to-end type safety between the Rust server and TypeScript client by using ts-rs to generate TypeScript types from Rust structs. This is a great improvement for maintainability and robustness. The refactoring of types into a central types.rs module on the server and consuming them on the client is well-executed. I've found a few issues, including a critical bug in the authentication middleware, a high-severity issue in a new React hook, and a medium-severity inconsistency in the type generation. Please see my detailed comments for suggestions on how to address these.