Expo-sdk-54 with react-native 0.81.1 #35
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a major version upgrade of the application's core mobile development frameworks, Expo SDK and React Native. The changes span across build configurations for both Android and iOS, dependency management, and native module initialization, aiming to align the project with the latest platform capabilities and improve overall development efficiency.
Highlights
- Core Framework Upgrades: The application has been upgraded to Expo SDK 54 and React Native 0.81.1, bringing the project up to date with the latest mobile development standards and features.
- Android Build System Enhancements: Significant changes were made to the Android build configuration, including updating R8 optimization property names, introducing a REACT_NATIVE_RELEASE_LEVEL build config field, and modernizing the React Native initialization process in MainApplication.kt to support the New Architecture.
- iOS Build Process Streamlining: The iOS dependency management has been simplified by removing Gemfile and Gemfile.lock. The Podfile was updated to leverage prebuilt React Native frameworks, include MMKVCore, and remove outdated Xcode 14 code signing workarounds, resulting in a more efficient build setup.
- Deep Linking Integration: A new deep linking scheme, exp+noahs-ark-wallet, has been consistently integrated across both Android and iOS configurations, enhancing the application's ability to handle external links.
- Dependency and Tooling Updates: Numerous third-party dependencies have been updated to their latest compatible versions, and patch-package has been integrated into the postinstall script to ensure proper management of any necessary patches for updated packages.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the project to Expo SDK 54 and React Native 0.81.1, which includes a wide range of dependency upgrades and configuration changes for both Android and iOS platforms. The changes are largely in line with what's expected for such a major version bump, including adjustments to build scripts, native project files, and API usage in the source code. However, I've identified critical errors in the Android Gradle wrapper scripts (gradlew and gradlew.bat) that need to be addressed. The modifications to these scripts are syntactically incorrect and will likely cause build failures.
* Initial migration commit * Download new gradle-wrapper.jar binary. * Fix mmkv breaking changes after it's been migrated to nitromodules. * Patch react-native-turbo-fs for android. * ios fixes * iOS podlock fixes * Try enough times and it works? this is so retarded. * Fix typescript errors. * make unused vars a warning and not an error in eslint. * make ios prebuild with --repo-update * Updated checksums for podfile.lock * one more try. * Switch to using bun's built-in package patch manager.
No description provided.