Use bip 321 parser

[niteshbalusu11]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's payment handling by adopting the bip-321 library. This change centralizes and strengthens the validation and parsing of various Bitcoin-related payment destinations, ensuring better adherence to standards and improved network compatibility. It also introduces infrastructure for tracking Lightning payment preimages and automates the logging of incoming Lightning transactions.

Highlights

• BIP-321 Parser Integration: The bip-321 library has been integrated to provide robust parsing and validation for Bitcoin Payment Request URIs, replacing custom validation logic across the application.
• Standardized Payment Destination Validation: All payment destination validation (for on-chain Bitcoin addresses, Lightning invoices, and Ark addresses) now leverages the bip-321 library, ensuring consistent and accurate checks, including network compatibility.
• Enhanced BIP-321 URI Handling: The parsing of BIP-321 URIs has been improved to correctly extract multiple payment methods and amounts, and the generation of these URIs now follows BIP-321 conventions more closely, using an empty path for unified QR codes.
• Transaction Preimage Support: The database schema has been updated with a new migration to include a preimage column in the transactions table, and the transaction recording logic has been modified to store this information for Lightning payments.
• Automatic Incoming Lightning Transaction Recording: Incoming Lightning payments received via push notifications are now automatically recorded in the local transaction database, including relevant details like amount, date, and BTC price at the time of receipt.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the destination parsing and validation logic to use the bip-321 library, which is a great improvement for robustness and maintainability. The changes are well-contained and the related updates to database migrations and transaction handling are consistent. I've found a couple of areas for improvement: one is to ensure the preimage is stored for incoming lightning transactions, and the other is to clarify error handling in the new BIP-321 parsing logic. Overall, this is a solid contribution.