Conversation
chaeyuuu
approved these changes
Jul 14, 2025
Comment on lines
+15
to
+24
|
|
||
| @CreatedDate | ||
| @Column(name = "created_at", updatable = false, nullable = false) | ||
| private LocalDateTime createdAt; | ||
|
|
||
| @LastModifiedDate | ||
| @Column(name = "updated_at", nullable = false) | ||
| private LocalDateTime updatedAt; | ||
|
|
||
| } |
Comment on lines
+24
to
+26
| @NotBlank | ||
| private String password; | ||
|
|
Contributor
There was a problem hiding this comment.
비밀번호 형식은 프론트에서 확인하고 넘겨받으니 따로 체크안하는걸로 이해하면 될까요?
Contributor
Author
There was a problem hiding this comment.
넵넵! 중복 체크할 필요없다고 생각했습니담
| @AllArgsConstructor | ||
| @Builder | ||
| @Getter | ||
| @SQLRestriction("deleted_at IS NULL") |
Contributor
There was a problem hiding this comment.
deleted_at으로 관리하는 것도 좋은데, BaseStatus라는 클래스에서 상태값 Y,N로 관리하는 방식도 있더라고요! 한 번 보시면 좋을 것 같습니담!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Related Issue
closed #12
🚀 Work Description
@SQLRestriction("deleted_at IS NULL")설정하여 자동 필터링 도입하였습니다. 현재로는 삭제된 User나 Guardian의 조회가 어떤 기능에서도 필요하지 않은 것으로 생각됩니다.🙇🏻♀️ To Reviewer