Skip to content

[Fix] 배포 파일 수정#87

Merged
chaeyuuu merged 1 commit intomainfrom
refactor/add-redis
Sep 4, 2025
Merged

[Fix] 배포 파일 수정#87
chaeyuuu merged 1 commit intomainfrom
refactor/add-redis

Conversation

@chaeyuuu
Copy link
Copy Markdown
Contributor

@chaeyuuu chaeyuuu commented Sep 4, 2025

🚀 Work Description

  • deploy.yml 파일 수정

Summary by CodeRabbit

  • Chores
    • 배포 파이프라인의 컨테이너 실행 구성을 개선하여 host.docker.internal 해석을 지원, 내부 서비스/호스트 간 연결 안정성과 호환성을 향상했습니다.
    • 기존 헬스체크, Nginx 포트 전환, 정리 절차는 그대로 유지되어 무중단 배포 흐름에 영향이 없습니다.
    • 배포 중 네트워크 관련 오류 가능성을 낮추고 운영 안정성을 강화했습니다.
    • 애플리케이션 기능 및 UI에는 변경 사항이 없습니다.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

GitHub Actions 배포 워크플로에서 docker run을 단일 행에서 다중 행으로 변경하고, 컨테이너 내부에 host.docker.internal DNS를 매핑하기 위해 --add-host=host.docker.internal:host-gateway 플래그를 추가했습니다. 헬스체크, Nginx 포트 스위칭, 정리 절차는 그대로입니다.

Changes

Cohort / File(s) Summary
배포 워크플로 수정
.github/workflows/deploy.yml
docker run을 멀티라인으로 변경하고 --add-host=host.docker.internal:host-gateway 추가. 기존 옵션 -d, --name $NEW_NAME, -p $NEW_PORT:8080, 이미지 참조 유지. 나머지 배포 흐름(헬스체크, Nginx 스위칭, 클린업) 변경 없음.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant GH as GitHub Actions
    participant R as Runner
    participant D as Docker Daemon
    participant C as App Container
    participant N as Nginx

    Dev->>GH: Push/Dispatch deploy workflow
    GH->>R: Execute deploy.yml
    R->>D: docker run -d --name $NEW_NAME -p $NEW_PORT:8080<br/>--add-host=host.docker.internal:host-gateway
    note right of D: 컨테이너 내부에서 host.docker.internal<br/>→ host-gateway로 해석 가능
    D-->>R: Container started
    R->>C: Health-check loop (HTTP 200 검사)
    alt Health OK
        R->>N: Switch upstream to $NEW_PORT
        R->>D: Cleanup old container
    else Health Fail
        R->>D: Stop and remove $NEW_NAME
        R-->>GH: Fail job
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • [Fix] deploy.yml 파일 수정 #61 — 동일한 .github/workflows/deploy.yml의 컨테이너 처리 로직을 수정하며 NEW_NAME 변수를 공통으로 사용. 본 PR은 docker run 플래그 추가, 관련 PR은 헬스체크 로깅/클린업 정정.

Suggested labels

🐞 BugFix

Poem

배포 토끼, 깡총깡총 밤길을 달려
컨테이너 속 별 하나, host.docker.internal 밝혀
게이트웨이 다리 놓고 포트는 딱 맞춰
헬스체크 통과하면 Nginx에 살짝 스위치
오늘도 무중단, 귀는 바람 따라 휘익 🥕


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cbb2e96 and 6ce4d78.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/add-redis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chaeyuuu chaeyuuu merged commit 42f7f6e into main Sep 4, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant