Conversation
…ion failures ClawRouter had @solana/kit@^6.0.0 (v6.1.0) while @x402/svm depended on @solana/kit@^5.0.0 (v5.5.1), creating two separate runtime copies of @solana/signers and @solana/transactions. Signers created with v6 and passed to @x402/svm's v5 ExactSvmScheme produced cross-version incompatible signatures, causing the facilitator to fail with transaction_simulation_failed. - Pin @solana/kit to ^5.0.0, deduplicating to single v5.5.1 - Add transaction_simulation_failed error handling in proxy - Detect simulation failures as payment errors for fallback chain
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Solana Kit dependency from version 6 to version 5 in package.json and enhanced payment error handling in the proxy module to detect and respond to Solana transaction simulation failures with fallback behavior to the free model when applicable. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solana/kitfrom^6.0.0to^5.0.0, deduplicating to a single v5.5.1 across the dependency tree (removed 42 redundant packages)transaction_simulation_failederror handling in proxy with user-friendly messaging and debug loggingRoot Cause
ClawRouter had
@solana/kit@6.1.0at top-level while@x402/svminternally used@solana/kit@5.5.1. This created two separate runtime copies of@solana/signersand@solana/transactions. Signers created with v6 and passed to@x402/svm's v5ExactSvmSchemeproduced cross-version incompatible signatures duringpartiallySignTransactionMessageWithSigners, causing the PayAI facilitator to fail simulation withtransaction_simulation_failed.Test plan
npm run buildsucceedsnpm test— 297 passed, 0 failed@solana/kit@5.5.1across entirenode_modulestreeSummary by CodeRabbit