fix: preserve user-defined blockrun/* allowlist entries across restarts#84
Merged
fix: preserve user-defined blockrun/* allowlist entries across restarts#84
Conversation
injectModelsConfig() was destructively pruning any blockrun/* key in agents.defaults.models that wasn't in TOP_MODELS, silently deleting entries users had manually added (e.g. blockrun/openai/gpt-5.4). Switch to additive-only behaviour: only add missing TOP_MODELS entries, never remove user-defined keys. Fixes #82.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe changes replace the plugin's destructive allowlist normalization logic with an additive approach that preserves user-defined blockrun entries while ensuring TOP_MODELS are present. Additionally, test integration setup shifts from static to dynamic worker-scoped port allocation using a computed port value. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectModelsConfig()was destructively deleting anyblockrun/*entry inagents.defaults.modelsthat wasn't in the curatedTOP_MODELSlist on every plugin load/gateway restartblockrun/openai/gpt-5.4) would see them silently pruned, causing "Model not allowed" errorsFixes #82.
Test plan
blockrun/*entry toagents.defaults.modelsin~/.openclaw/openclaw.jsonopenclaw gateway restart)openclaw models status --json)npm test)Summary by CodeRabbit