fix(update.sh): match reinstall.sh's OKX-first install flow#5
Merged
Conversation
scripts/update.sh — which is what users actually hit when they run the live `curl https://blockrun.ai/XClawRouter-update | bash` command — was missing the OKX-first bootstrap that scripts/reinstall.sh already had. Net effect: users running the official one-liner saw: - no `Bootstrapping OKX Agentic Wallet` section - no `Next step — log in to your OKX Agentic Wallet` block - a misleading "New wallet will be generated on next gateway start" message (the plugin no longer auto-generates one, so users would refresh the gateway and silently end up with no wallet at all) Bring the two scripts in sync: - Add the same `→ Bootstrapping OKX Agentic Wallet (onchainos)...` preflight that auto-installs the binary via OKX's install.sh, or skips when XCLAWROUTER_SKIP_OKX_INSTALL=1 / an existing local wallet / opt-in env var is present. - Replace the misleading post-install fallthrough message with one that explains the user will use the OKX wallet via the upcoming Next step. - Add the same `Next step — log in to your OKX Agentic Wallet` block at the end of the script, gated on the same "wallet not already set up" condition. scripts/update.ps1 (PowerShell sibling) still needs the same treatment; tracked separately.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/update.sh— the script users actually hit when they run the livecurl https://blockrun.ai/XClawRouter-update | bashone-liner — was missing the OKX-first bootstrap thatscripts/reinstall.shalready had.End result: users running the official one-liner installed the new plugin (v0.12.182) but saw:
Bootstrapping OKX Agentic Walletsection (no onchainos auto-install)Next step — log in to your OKX Agentic Walletblock (so they didn't know to runxclawrouter setup)New wallet will be generated on next gateway startmessage — the plugin no longer auto-generates one, so users refreshed the gateway and silently ended up with no wallet at allWhat
Bring
update.shin sync withreinstall.sh:→ Bootstrapping OKX Agentic Wallet (onchainos)...preflight that auto-installs the binary via OKX'sinstall.sh, with the existing escape hatches (XCLAWROUTER_SKIP_OKX_INSTALL=1, existingwallet.key,XCLAWROUTER_USE_LOCAL_WALLET=1).Next step — log in to your OKX Agentic Wallet: npx @blockrun/xclawrouter setupblock at the end, gated on the same "not already set up" condition.Not in scope
scripts/update.ps1(PowerShell sibling) needs the same treatment — tracked separately.Test plan
bash -n scripts/update.sh— syntax cleancurl … | bashURL: install completed but no OKX guidance shown, gateway restarted with no wallet, plugin silently failedscripts/update.shend-to-end: OKX bootstrap section appears, no misleading "wallet will be generated" line,Next stepblock prints at the end