Check in the Cargo.lock file to fix bumpalo dependency #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cargo.lock should be checked in anyway as we are building a cdylib Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bumpalo library recently released version 3.12.1, which, unlike 3.12.0, does not build in Rust 1.59.0. Because of this, the v1.13 branch of this plugin doesn't build. In order to fix this we need to use an earlier version of bumpalo. Version 3.12.0 works, but the v1.13 validator has it locked to 1.3.8 so I have done the same. In order to lock the version I have added the Cargo.lock to the repo.
The Cargo.lock should be checked in anyway because we are building a cdylib, as documented here
I have not gone through and matched all the versions in the lock file with those of the validator, as this should not be necessary.