diy: waveshare lcd touch 2 improvements#230
Closed
trevarj wants to merge 4 commits into
Closed
Conversation
- Added battery voltage and status - Added USB connectivity check (guess from ADC voltage) - Added sleep/wake using BOOT button - Enabled display brightness setting
Collaborator
|
Cheers - I'll take a look next week. 👍 |
Contributor
Contributor
Author
|
@harinworks Thanks for the fixes! Would you mind putting that PR up against my repo instead? Then I can merge it there and it will show up on this PR. |
Contributor
|
@trevarj Done! Please check your repo :) |
Refactor wslcdtouch2.inc for better code clarity
Collaborator
|
Sorry for the delay on my part - I've run the latest through our internal ci and all seems good. |
Contributor
Author
|
@JamieDriver all good on my end. Been testing and everything seems to be working fine. Thanks a lot! |
Collaborator
|
Rebased and merged to master at a5c9eab. Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got pretty excited that there is a confirmed one whole extra person using this board besides me, so I finally put my head down and finished a few things that were bothering me and improving the device's usability.
Battery and backlight are taken from Waveshare's examples and adjusted slightly.