gl-sdk: Add node_id() getter on Credentials#703
Merged
Conversation
Exposes the node_id derived from the device certificate through the UniFFI boundary, matching the existing Signer::node_id() getter. Closes #644 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_id()getter ongl-sdk'sCredentialsstruct, delegating to the innergl_client::credentials::Device'sNodeIdProviderimplementation.Signer::node_id()getter so consumers of the UniFFI bindings can retrieve the node id directly from persisted credentials, without spinning up a signer.Closes #644
Test plan
cargo build -p gl-sdksucceeds🤖 Generated with Claude Code