gl-sdk: Add C++ bindings#718
Merged
Merged
Conversation
Collaborator
|
Excellent addition @ardier16, thank you 🙏 Can we add a generation run in CI as a followup, so we can ensure that the CPP stub generation works as expected, and we don't accidentally break it? |
cdecker
approved these changes
May 20, 2026
| /// immediately without I/O. | ||
| /// | ||
| /// Strips `lightning:` / `LIGHTNING:` prefixes automatically. | ||
| #[cfg(not(feature = "cpp-bindings"))] |
Collaborator
There was a problem hiding this comment.
We can make the entirety of the API sync, and then running async code inside of the Rust crate only. This would mean all the APIs are the same regardless of the host language are sync-only.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds C++ bindings support to
gl-sdk:cpp-bindingsfeature and C++ compatibleresolve_inputexport.task sdk:bindings-cppand include it intask sdk:bindings-all.uniffi-bindgen-cppplusperlpost-processing to rename generatedregisteridentifiers toregister_node.