Skip to content

Display confidential addresses for outputs#2

Merged
miketlk merged 3 commits intoliquid_developfrom
tmp_display_confidential_address
Apr 10, 2025
Merged

Display confidential addresses for outputs#2
miketlk merged 3 commits intoliquid_developfrom
tmp_display_confidential_address

Conversation

@miketlk
Copy link
Copy Markdown
Collaborator

@miketlk miketlk commented Apr 10, 2025

Summary

Display confidential addresses for outputs. The logic for address display is simple: when an output has PSBT_ELEMENTS_OUT_BLINDING_PUBKEY, its address is displayed as confidential. Otherwise, it's displayed as unconfidential.

Changes

  • In signing workflow, outputs having blinding pubkey are displayed with confidential address
  • get_script_callback() from get_wallet_address.c refactored into globally available get_wallet_script_callback()

Testing

Tests in tests_liquid are being updated with new snapshots having confidential addresses.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 82.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miketlk miketlk merged commit 0a02121 into liquid_develop Apr 10, 2025
26 checks passed
@miketlk miketlk deleted the tmp_display_confidential_address branch April 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants