Support multi-file error enrichment using SourceFile#266
Merged
KyrylR merged 1 commit intoBlockstreamResearch:dev/importsfrom Apr 1, 2026
Merged
Conversation
SourceFile
KyrylR
reviewed
Apr 1, 2026
src/error.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn with_file(self, file: Arc<str>) -> Self { |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub fn with_file(self, file: Arc<str>) -> Self { | |
| pub fn with_file(self, program_content: Arc<str>) -> Self { |
KyrylR
reviewed
Apr 1, 2026
src/error.rs
Outdated
Comment on lines
224
to
229
| pub fn file(&self) -> Option<Arc<str>> { | ||
| match &self.error_context { | ||
| Some(ErrorContext::Content(file)) => Some(Arc::clone(file)), | ||
| _ => None, | ||
| } | ||
| } |
KyrylR
reviewed
Apr 1, 2026
src/error.rs
Outdated
| write!(f, "{:^<width$} ", "", width = underline_length)?; | ||
| write!(f, "{}", self.error) | ||
|
|
||
| /* |
KyrylR
reviewed
Apr 1, 2026
80aa418 to
4084255
Compare
Collaborator
|
To avoid ambiguity with RichError, maybe it is better to have the following API shape:
Then clean up the API surface:
|
4084255 to
2dbadee
Compare
Collaborator
Author
I did not change it because doing so could break the entire parser logic |
2dbadee to
816b746
Compare
Collaborator
Author
The |
816b746 to
d8a81f3
Compare
d8a81f3 to
026c0ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we will support modules, we need to know exactly where the error happened. Also, for single-file programs, nothing has changed, and the errors will be displayed the same way.