Implement Program AST generation in the Driver#280
Merged
KyrylR merged 1 commit intoBlockstreamResearch:dev/importsfrom Apr 13, 2026
Merged
Implement Program AST generation in the Driver#280KyrylR merged 1 commit intoBlockstreamResearch:dev/importsfrom
KyrylR merged 1 commit intoBlockstreamResearch:dev/importsfrom
Conversation
LesterEvSe
force-pushed
the
feature/resolve-order
branch
from
2e81bb1 to
ccc8c48
Compare
KyrylR
requested changes
Apr 13, 2026
src/driver/resolve_order.rs
Outdated
Comment on lines
+118
to
+128
| // 2. Ignore Modules | ||
| if matches!(elem, parse::Item::Module) { | ||
| continue; | ||
| } | ||
|
|
||
| // 3. Handle Types & Functions | ||
| let (name, vis) = match elem { | ||
| parse::Item::TypeAlias(a) => (a.name().as_inner(), a.visibility()), | ||
| parse::Item::Function(f) => (f.name().as_inner(), f.visibility()), | ||
| _ => unreachable!(), | ||
| }; |
Collaborator
There was a problem hiding this comment.
Combine those two instead of using unreachable
src/driver/resolve_order.rs
Outdated
Comment on lines
+135
to
+143
| if handler.has_errors() { | ||
| None | ||
| } else { | ||
| Some(Program { | ||
| items: items.into(), | ||
| files: construct_resolved_file_array(&self.paths, &resolutions), | ||
| span: *self.modules[0].parsed_program.as_ref(), | ||
| }) | ||
| } |
LesterEvSe
force-pushed
the
feature/resolve-order
branch
from
ccc8c48 to
63e5daf
Compare
LesterEvSe
force-pushed
the
feature/resolve-order
branch
from
63e5daf to
4b0b834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the previously written driver functionality to construct the unified
ProgramAST structure.Also, some errors were corrected here. For now, it's difficult to create effective error handling with the current type of handler, so this will be a task outside of these series of module PRs.