change NUMS key to bip 0341 one #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next commit will change the "unspendable key" from the sketchy one whose provenance we can't figure out, to the BIP 341 one which is provably unspendable. For now, refactor these functions so that we will be able to do more flexible things with these Taptrees than just generating addresses.
Contributor
Author
canndrew
reviewed
Nov 10, 2025
src/hal_simplicity.rs
Outdated
| } | ||
| } | ||
|
|
||
| // Stolen from simplicity-webide |
Contributor
There was a problem hiding this comment.
Probably a good idea to change this comment and explain where the key came from. eg. include this link
Our current "unspendable key" comes from the Simplicity web IDE (from where it was copied to several other places, oops). However, this key seems to come from an old rust-simplicity unit test where it wasn't described as being "unspendable" and which we suspect that a private key was once known.
apoelstra
force-pushed
the
2025-11/nums-key
branch
from
5380c16 to
1d211d6
Compare
Contributor
Author
|
Updated. |
Contributor
|
ACK 1d211d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.