WASM FFI #204
Merged
WASM FFI #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
reviewed
Jan 31, 2024
Copied from https://github.com/rust-bitcoin/rust-secp256k1/tree/97dade55812765e0c6ddce44377d9ccd8d97f54b/secp256k1-sys/wasm Added printf dummy to stdio.h
Bind all C types that are used in libsimplicity. Prefix these types with c_. Define types like UWORD by these types, like in the C code. Verify these types in unit tests.
Remove dependency on libc
Disabled because file doesn't exist yet.
uncomputable
force-pushed
the
wasm-ffi
branch
from
8d42aa0 to
f7de51e
Compare
Collaborator
Author
|
Rebased onto master. Extended the existing C type definitions and tests. Removed wrapper.h because the file will be vendored. |
Collaborator
|
utACK f7de51e. Will run my local CI (though this does not include any wasm testing, at least for now). Would you like this to be merged or do we want to wait for wrappers.h to be changed upstream? |
apoelstra
reviewed
Feb 5, 2024
| /* This file has been automatically generated. */ | ||
|
|
||
| use std::ffi::c_void; | ||
| use crate::ffi::c_void; |
Collaborator
There was a problem hiding this comment.
In 8e7f59b:
You are not allowed to change this file directly. It needs to be changed upstream and then pulled in by the vendoring script.
Collaborator
Author
|
Let's merge this PR first and then match the changes in BlockstreamResearch/simplicity#218. Feel free to run your test suite |
Collaborator
|
My test suite will not pass if you are modifying files that originate in the upstream library. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the FFI to work with WASM.
Remove dependency on libc. Fix definition of
UWORD, which isu16on WASM !=u32 = usize. Prepare for wrapped jets.