Elements Miniscript rev 2022-03 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This does not compile with rustc 1.41.0 and Looking at CI, it appears that we misspell Can you fix both things? |
Collaborator
|
Actually, even on master fails to compile. (It does compile with just |
Merged
Collaborator
Author
|
@apoelstra I opened PR #23. Please check if it does what you proposed. I will rebase this PR afterwards. |
apoelstra
added a commit
that referenced
this pull request
Apr 22, 2022
0385213 Fix Github CI (Christian Lewe) 3d5404b Remove dependency of elements upon bitcoin (Christian Lewe) Pull request description: Remove dependency of (implicit) feature `elements` upon `bitcoin` by using `elements::bitcoin`. Fix GitHub CI to test for successful compilation using each of these features separately. Proposed in #21. ACKs for top commit: apoelstra: ACK 0385213 Tree-SHA512: eb34fdc5644c429d88cbfa611cc9efdd71b85832a9952a4a9099a032c5f7b29f3437a5685b6a8d438653c97966348e0bd5bafcfca09fd829604fce55ce86a9b7
uncomputable
force-pushed
the
elements_miniscript_rev_2022_03
branch
from
507995f to
90b4591
Compare
apoelstra
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest combination of
rust-bitcoin,rust-elementsandrust-miniscript.Todo
Cargo.tomlafter official release ofrust-bitcoinv0.28.0,rust-miniscriptv7.0.0 andrust-elementsv0.19.0 (?)