-
Notifications
You must be signed in to change notification settings - Fork 19
Fix features #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix features #23
Conversation
d59977b to
8bc817f
Compare
|
I think there are two different ways of looking at features here:
I think we should classify our features by the latter method. If possible in rust, we should also mark features as incompatible with each other. That is, you can run in both elements and the bitcoin feature. |
|
@sanket1729 unfortunately we can't make features incompatibile with each other, so we have made sure that it is possible to have both features enabled. The problem that this PR addresses is that right now you can't have |
|
@chlewe I would like it to be possible to use Making the dependency explicit fixes the compilation issue but I'd like to remove the dependency. Heads up that you can access the rust-bitcoin crate through rust-elements, as |
8bc817f to
fb70130
Compare
fb70130 to
0385213
Compare
|
As far as I can see, the namespaces of features and dependencies get properly separated in Rust 1.60. In earlier versions, implicit features cannot enable other features / dependencies because implicit features are defined in |
|
@chlewe the two features are not incompatible, are they? This fix looks great, exactly what I was looking for. If there are actual incompatibilties we should find and fix those but they can wait.. |
apoelstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0385213
|
Right now, all features are compatible and no feature depends on another. |
Remove dependency of (implicit) feature
elementsuponbitcoinby usingelements::bitcoin. Fix GitHub CI to test for successful compilation using each of these features separately.Proposed in #21.