A few multi-hop-locks clarification#18
Merged
jonasnick merged 1 commit intoBlockstreamResearch:masterfrom Dec 7, 2019
Merged
Conversation
jonasnick
reviewed
Dec 6, 2019
Collaborator
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
Thanks! ACK mod nit. In general I prefer sender/receiver vs payer/payee because the latter looks so similar but after this PR changing that would just be copy and paste.
Contributor
Author
I agree, I chose to stick with payer/payee because it was what was initially there, but I'll change it to sender/recipient now. |
* Fixed a few typos * Fixed a small error in the update phase of the flow diagram * Harmonized terms payer/payee * Added a few clarifications (from the LN's point of view) * Some markdown linting
t-bast
force-pushed
the
multi-hop-locks-clarifications
branch
from
2f2659f to
5c6513d
Compare
jonasnick
approved these changes
Dec 7, 2019
Collaborator
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
excellent, thanks. ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dived again into this whole document, and did the following:
All clarifications are personal: things I thought were a bit clearer with the changes proposed. This is highly subjective, so don't hesitate to tell me if you want me to remove some of those changes.
I'm now familiar enough with the whole construction, so my next PR after this one will add the stuckless/cancellable feature (finally 😃)