Skip to content

Add clippy ci entry#24

Merged
Arvolear merged 2 commits intodevfrom
chore/clippy
Mar 20, 2026
Merged

Add clippy ci entry#24
Arvolear merged 2 commits intodevfrom
chore/clippy

Conversation

@ikripaka
Copy link
Collaborator

@ikripaka ikripaka commented Mar 18, 2026

chore:

  • add updated basic Cargo.lock file from example
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

Add clippy and fix lints.

@ikripaka ikripaka marked this pull request as ready for review March 18, 2026 17:09
@ikripaka ikripaka requested a review from Arvolear as a code owner March 18, 2026 17:09
@ikripaka
Copy link
Collaborator Author

Why did I change &Box to &dyn ProgramTrait?
https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#borrowed_box

@ikripaka ikripaka self-assigned this Mar 20, 2026
@Arvolear Arvolear changed the base branch from master to dev March 20, 2026 11:26
Copy link
Collaborator

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 3c6ec4d into dev Mar 20, 2026
7 checks passed
@Arvolear Arvolear deleted the chore/clippy branch March 20, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants