Skip to content

Minor refactoring#65

Merged
Arvolear merged 3 commits into
devfrom
feature/ref-1
Apr 29, 2026
Merged

Minor refactoring#65
Arvolear merged 3 commits into
devfrom
feature/ref-1

Conversation

@KyrylR
Copy link
Copy Markdown
Collaborator

@KyrylR KyrylR commented Apr 29, 2026

  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

@KyrylR KyrylR requested a review from Arvolear as a code owner April 29, 2026 06:26
@KyrylR
Copy link
Copy Markdown
Collaborator Author

KyrylR commented Apr 29, 2026

Link: https://cdla.dev/permissive-2-0/

@KyrylR
Copy link
Copy Markdown
Collaborator Author

KyrylR commented Apr 29, 2026

Link: cdla.dev/permissive-2-0

This one is from LWK, and here is a AI summary of the differences:

Short answer: MIT-like in spirit, but not the MIT license. It is a permissive license designed specifically for data, not software code.

Main differences:

Topic MIT License CDLA Permissive 2.0
Primary target Software Data / datasets
Permission Use, copy, modify, merge, publish, distribute, sublicense, sell software Use, modify, and share data
Redistribution condition Include copyright notice and MIT license text Include the CDLA license text with shared data
Outputs/results Not separately discussed Explicitly says Results are unrestricted, including ML models and model insights
Warranty/liability No warranty, no liability Similar “as is” and liability disclaimer
Copyright notice MIT requires preserving copyright notice CDLA 2.0 requires making the agreement text available; it is less copyright-notice-centered
Sublicensing MIT expressly allows sublicensing CDLA focuses on sharing data under the agreement; results are unrestricted

The biggest practical difference is this: CDLA Permissive 2.0 lets you use a dataset, modify it, redistribute it with the license text, and use outputs/results without restrictions. That makes it broadly permissive like MIT, but it is more tailored to data and ML workflows.

For ML use: if you train a model on CDLA Permissive 2.0 data, the license explicitly says it does not impose restrictions or obligations on the resulting model or insights.

Sources: CDLA Permissive 2.0, MIT License - OSI

Not sure how it got into LWK, but at the same time it does not cover code at all, so yeah

@Arvolear Arvolear changed the base branch from master to dev April 29, 2026 09:38
Copy link
Copy Markdown
Collaborator

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 40990fc into dev Apr 29, 2026
9 checks passed
@Arvolear Arvolear deleted the feature/ref-1 branch April 29, 2026 09:41
Arvolear added a commit that referenced this pull request May 12, 2026
* fix badge

* smplx_generator: add rustfmt::skip (#63)

* Log level attribute for `simplex::test` (#61)

* impl log level attribute for test macro

* add global log level loaded from config

* control global logging level via cli command

* some refactor

* refactor and clean up changes from prev commits

* cleanup

* readme

* fix build

---------

Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>

* Minor refactoring (#65)

* Fix/reissuance (#66)

* Add ReissuanceInput and update FinalTransaction functions

* Refactor FinalInput struct

* Refactor FinalTransaction; add reissuance test

* Move ReissuanceInput logic to the IssuanceInput

* Convert IssuanceInput to enum

* Change IssuanceInput fields order

* smplx_sdk: add wrapper over Txid for wait behaviour (TxReceipt) (#62)

* smplx_sdk: add wrapper over Txid for wait behaviour

- add simplex::transaction::TxReceipt type to wrap behavior over Txid. In this way we need to wait Txid for completing instead of invoking provider
- function to wait elements::Txid remained inplace
- align tests

# Conflicts:
#	fixtures/tests/basic_test.rs
#	fixtures/tests/confidential_test.rs
#	fixtures/tests/nested_sig.rs

* Apply suggestion from @Arvolear

---------

Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

* Add possibility to use NetworkUtils on tests (#68)

* smplx_test: add possibility to run network utils on tests

- add generate_blocks endpoint to ProviderTrait
- add function to generate desired block height in test
- add test for it

* smplx_test: fix lints

* Apply suggestions from code review

Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

---------

Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

* [refactor] Add `simplex new` and `simplex example` commands (#67)

* add new and example commands

* comment out test exec and add reference to example

* remove `example` command and move `new` to `init`

* initialize rust lib with config by default

* Apply suggestion

---------

Co-authored-by: stringhandler <stringhandler@protonmail.com>
Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

* Add filters logic to the CLI test command (#72)

* Add more arguments to the CLI test command

* Add TODO

* Docs (#70)

* assets: add logo imgs

* smplx: add extended clippy linting

* add readme for smplx-sdk

* smplx: add extended clippy linting

* fix lints, which aren't related to docs

# Conflicts:
#	crates/cli/src/commands/core.rs
#	crates/cli/src/commands/init.rs

# Conflicts:
#	crates/cli/src/commands/test.rs

* smplx_test: fix typo in mine_until_height when returning Err value on success

* docs: fix clippy doc lints

# Conflicts:
#	crates/cli/src/cli.rs
#	crates/cli/src/commands/test.rs

* docs: change "asset id" on `AssetId`

* docs: remove custom lints from smplx-std Cargo.toml

* add additional lint to crates::sdk::lib.rs
* add additional lints to root Cargo.toml

* generator: add must_use attribute

* smplx-sdk readme

* Apply suggestions from code review

Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

---------

Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>
Co-authored-by: Artem Chystiakov <47551140+Arvolear@users.noreply.github.com>

* rename a program function (#74)

* quick doc fix

* changelog

* version

* upd changelog

---------

Co-authored-by: Illia Kripaka <30872146+ikripaka@users.noreply.github.com>
Co-authored-by: Vitalii Volovyk <161724671+topologoanatom@users.noreply.github.com>
Co-authored-by: Kyrylo Riabov <kyryl.ryabov@gmail.com>
Co-authored-by: Oleh Komendant <44612825+Hrom131@users.noreply.github.com>
Co-authored-by: stringhandler <stringhandler@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants