Skip to content

Fix filtering when searching for languages in app-hosted mode (BL-15822) #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnThomson merged 1 commit into from
Feb 6, 2026
Merged

Fix filtering when searching for languages in app-hosted mode (BL-15822) #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/appHosted/AppHostedLanguageGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,16 @@ export const AppHostedLanguageGroup: React.FunctionComponent = () => {
getItemProps: (options: GetItemPropsOptions<any>) => {},
getMenuProps: (options: GetMenuPropsOptions) => {}
) => {
languagesToDisplay = getLanguagesMatchingSearchTerm(searchTerm).filter(
(lang) => preferredLangCodes.indexOf(lang.isoCode) < 0
);
const matchingLanguages = getLanguagesMatchingSearchTerm(searchTerm);
languagesToDisplay = matchingLanguages;
if (showPreferredLangs) {
// Filter out favorites from the main list so we don't show the same language twice.
// Note: it is important not to do this when favorites are hidden; else they won't show at all. BL-15822
languagesToDisplay = matchingLanguages.filter(
(lang) => !preferredLangCodes.includes(lang.isoCode)
);
}

const prefColor = commonUI.colors.bloomRed;
// if (!showAll && languagesToDisplay.length > 10) {
// languagesToDisplay.splice(10);
Comment thread
andrew-polk marked this conversation as resolved.
Expand Down