Prevent swiping pages when clicking on video buttons (BL-14021)#333
Prevent swiping pages when clicking on video buttons (BL-14021)#333
Conversation
hatton
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @JohnThomson)
src/bloom-player-core.tsx line 229 at r1 (raw file):
// runs more often. function handleInputMouseEvent(event: Event) { if ((event.target as HTMLElement).closest(".videoControlContainer")) {
Will this prevent swiping on the whole video? I was expecting that we would just be limiting to the buttons on the video. Might seem like a small difference if the video is small, but if it were full page?
JohnThomson
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hatton)
src/bloom-player-core.tsx line 229 at r1 (raw file):
Previously, hatton (John Hatton) wrote…
Will this prevent swiping on the whole video? I was expecting that we would just be limiting to the buttons on the video. Might seem like a small difference if the video is small, but if it were full page?
No. VideoControlContainer is a class applied to the div that surrounds each of the button SVGs. Swiper behavior is only interfered with on the buttons themselves.
hatton
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)
|
🎉 This PR is included in version 2.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change is