Skip to content

Conversation

@andrew-polk
Copy link
Collaborator

@andrew-polk andrew-polk commented Jan 22, 2026

Show back button and better message


This change is Reviewable

Copy link
Member

@hatton hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hatton made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @andrew-polk).


src/bloom-player-core.tsx line 934 at r1 (raw file):

            msg = "<p>We could not find that book.</p>";
        }

At this point, would it be correct to wrap the following in an else? I can't tell whether we think that we could get this message but then later decide to change the message. If we know that we would not change the message, then an else would make that clear.

Copy link
Collaborator Author

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @hatton).


src/bloom-player-core.tsx line 934 at r1 (raw file):

Previously, hatton (John Hatton) wrote…

At this point, would it be correct to wrap the following in an else? I can't tell whether we think that we could get this message but then later decide to change the message. If we know that we would not change the message, then an else would make that clear.

Good catch. Fixed.

@hatton hatton merged commit fe68be7 into alpha Jan 23, 2026
1 check was pending
@hatton hatton deleted the BL15692_FailBookNav branch January 23, 2026 15:43
@github-actions
Copy link

🎉 This PR is included in version 2.18.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants