fix: currency symbol formatting issue in child table#323
Merged
sahil28297 merged 3 commits intoBloomstack:developfrom Nov 16, 2020
Merged
fix: currency symbol formatting issue in child table#323sahil28297 merged 3 commits intoBloomstack:developfrom
sahil28297 merged 3 commits intoBloomstack:developfrom
Conversation
hrwX
commented
Nov 6, 2020
hrwX
commented
- Asana Task
- The currency was rendered incorrectly since parent doc was not being passed to the child table.
- Before
- After
Co-authored-by: Sahil Khan <sahilkhan28297@gmail.com>
rvpasari
reviewed
Nov 9, 2020
rvpasari
left a comment
rvpasari
left a comment
There was a problem hiding this comment.
These changes seem fine to me. Would probably recommend
blocks br
bhattdevarsh
approved these changes
Nov 12, 2020
sahil28297
approved these changes
Nov 16, 2020
sahil28297
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.