feat: Introduce CKEditor 5 as an alternate Text Editor #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dti-deploy create instance |
1 similar comment
|
@dti-deploy create instance |
|
An error occurred while executing the following command: |
* feat: Added buttons add all roles and clear all roles for user * Update frappe/public/js/frappe/roles_editor.js Co-authored-by: meshramsaroj <saroj@digithinit.com> Co-authored-by: Himanshu <himanshuwarekar@yahoo.com>
DeveloperMetal
requested changes
May 5, 2021
DeveloperMetal
left a comment
DeveloperMetal
left a comment
There was a problem hiding this comment.
Looking pretty good. Just a couple of super minor nitpicks.
frappe/public/js/frappe/form/controls/ckeditor-plugins/Base64UploadAdapter.js
Outdated
Show resolved
Hide resolved
DeveloperMetal
previously approved these changes
May 6, 2021
sahil28297
approved these changes
May 12, 2021
hrwX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: https://app.asana.com/0/1200226985565275/1200112141008329