feat: Mandatory depends on logic added #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch develop into staging
fix: comment disappear on edit issue fixed
Revert "fix: comment disappear on edit issue fixed"
fix: get content from shadow dom
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
vishdha
requested review from
hrwX and
sahil28297
and removed request for
sahil28297
hrwX
previously approved these changes
Jun 11, 2021
|
@vishdha fix Sider issues |
sahil28297
suggested changes
Jun 14, 2021
Author
Resolved |
sahil28297
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port from frappe#8820
ASNA Task: https://app.asana.com/0/1200414497004131/1200413538586244