Skip to content

Conversation

@MyuddinKhatri
Copy link

@MyuddinKhatri MyuddinKhatri commented Jun 24, 2021

  • added pagination and filter for addresses and contacts
  • moved address and contact link and delete customizations to frappe
    screencast-jhaudio_8008-2021 07 04-20_28_13

Bloomstack/erpnext#1403
Bloomstack/bloomstack_core#611

@MyuddinKhatri MyuddinKhatri marked this pull request as draft June 24, 2021 15:07
@MyuddinKhatri
Copy link
Author

@hrwX , @DeveloperMetal , @nehasacher143 I need to move the search Contact and Search address field above the listing, can you guys suggest me something?

Copy link

@DeveloperMetal DeveloperMetal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the search box above the addresses component. You can prepend a container update to do your work.

And as noted scope all your selectors, fetching general classes kills page performance and will add odd bugs on other parts of the page which are hidden and later displayed.

@sahil28297
Copy link

@MyuddinKhatri What's up with this PR? Also fix Sider issues

@MyuddinKhatri
Copy link
Author

@MyuddinKhatri What's up with this PR? Also fix Sider issues

need to change some css here

@MyuddinKhatri MyuddinKhatri marked this pull request as ready for review June 30, 2021 09:21
@MyuddinKhatri MyuddinKhatri requested a review from hrwX June 30, 2021 09:25
@MyuddinKhatri
Copy link
Author

@hrwX and @sahil28297 changes are done please have a look.

@sahil28297 sahil28297 requested a review from DeveloperMetal July 1, 2021 07:22
@MyuddinKhatri MyuddinKhatri requested a review from hrwX July 5, 2021 08:02
hrwX
hrwX previously approved these changes Jul 7, 2021
@hrwX
Copy link

hrwX commented Jul 7, 2021

@MyuddinKhatri Fix sider issues.

@MyuddinKhatri MyuddinKhatri changed the base branch from bs-jun-sprint-2 to bs-jul-sprint-1 July 7, 2021 05:03
@MyuddinKhatri MyuddinKhatri changed the base branch from bs-jul-sprint-1 to bs-jun-sprint-2 July 7, 2021 05:04
@MyuddinKhatri MyuddinKhatri force-pushed the address-contact-pagination branch from 3753155 to 898bd57 Compare July 7, 2021 05:11
@MyuddinKhatri MyuddinKhatri changed the base branch from bs-jun-sprint-2 to bs-jul-sprint-1 July 7, 2021 05:12
@MyuddinKhatri MyuddinKhatri requested a review from hrwX July 7, 2021 06:27
Copy link

@DeveloperMetal DeveloperMetal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see jquery selector scoping issues that can hurt browser performance. The .on(, , ) method will trigger every time an element is added to the dom specially from the document scope. You can limit that traversal by scoping to the current page.

nehasacher143
nehasacher143 previously approved these changes Jul 9, 2021
Copy link

@nehasacher143 nehasacher143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MyuddinKhatri Looks good to me

@DeveloperMetal @hrwX Please review

hrwX
hrwX previously approved these changes Jul 12, 2021
DeveloperMetal
DeveloperMetal previously approved these changes Jul 13, 2021
@sahil28297 sahil28297 dismissed stale reviews from DeveloperMetal and hrwX via 5489926 July 13, 2021 13:25
@sahil28297 sahil28297 merged commit 3746b8a into Bloomstack:bs-jul-sprint-1 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants