-
Notifications
You must be signed in to change notification settings - Fork 19
feat: added pagination and filter for addresses and contacts #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added pagination and filter for addresses and contacts #641
Conversation
|
@hrwX , @DeveloperMetal , @nehasacher143 I need to move the search Contact and Search address field above the listing, can you guys suggest me something? |
DeveloperMetal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the search box above the addresses component. You can prepend a container update to do your work.
And as noted scope all your selectors, fetching general classes kills page performance and will add odd bugs on other parts of the page which are hidden and later displayed.
|
@MyuddinKhatri What's up with this PR? Also fix Sider issues |
need to change some css here |
|
@hrwX and @sahil28297 changes are done please have a look. |
|
@MyuddinKhatri Fix sider issues. |
3753155 to
898bd57
Compare
DeveloperMetal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see jquery selector scoping issues that can hurt browser performance. The .on(, , ) method will trigger every time an element is added to the dom specially from the document scope. You can limit that traversal by scoping to the current page.
nehasacher143
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MyuddinKhatri Looks good to me
@DeveloperMetal @hrwX Please review
Bloomstack/erpnext#1403
Bloomstack/bloomstack_core#611