Skip to content

Fix for #90: SWC parser creates multiple soma sections.#94

Merged
hernando merged 1 commit intomasterfrom
swc_parser_fix
Sep 19, 2016
Merged

Fix for #90: SWC parser creates multiple soma sections.#94
hernando merged 1 commit intomasterfrom
swc_parser_fix

Conversation

@hernando
Copy link
Copy Markdown
Contributor

This happened when neurites were connected to arbitrary soma samples.

This happened when neurites were connected to arbitrary soma samples.
Copy link
Copy Markdown

@juanchopanza juanchopanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK to me, but I would prefer it if somebody else can also have a quick look.

Copy link
Copy Markdown
Contributor

@dnachbaur dnachbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me w/o knowing too much about SWC

@hernando
Copy link
Copy Markdown
Contributor Author

Just a minor comment. Notice that the current parser does two different things when the soma is given as a contour and as a point. When the soma is a point, the first order sections are not connected to that point (that would be wrong for several use cases: distance to soma computation, simple sphere + tubes rendering, ...). On the other hand, when the soma is described as a contour (or a tree), then the neurites are connected to the soma samples. This may not be always correct, but when that's the case the swc file should be fixed because that's how I interpret that case.

@juanchopanza
Copy link
Copy Markdown

@hernando I assume you're talking about the internal representation of morphologies. But how does this translate to SWC and H5 files written from a single point soma?

@hernando
Copy link
Copy Markdown
Contributor Author

The SWC ans H5 are already not fully equivalent and it's not possible to to SWC->H5->SWC and get the original result (that's not a big deal since there's no SWC writer anyway).
With this commit, the behaviour for single point somas has not changed compared to before. In that case the first point of a first order section is the point which has the soma sample as parent, i.e. the section is not extended adding the soma point as the first one.

@hernando hernando merged commit fb5f4b1 into master Sep 19, 2016
@hernando hernando deleted the swc_parser_fix branch September 19, 2016 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants