Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Clean code for #250 #421

Merged
pramodk merged 3 commits into from
Nov 18, 2020
Merged

Clean code for #250 #421

pramodk merged 3 commits into from
Nov 18, 2020

Conversation

@alkino
Copy link
Member

@alkino alkino commented Nov 12, 2020 •
edited
Loading

NEURON_BRANCH=master

pramodk
pramodk reviewed Nov 12, 2020
View reviewed changes
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - few minor comments.

Nicolas Cornu added 2 commits November 13, 2020 13:48
Replace assert(!busy) with nrn_assert
535720a 
nrn_assert is compiled too when in release mode.
Using using instead of typedef
b052448
pramodk
pramodk suggested changes Nov 13, 2020
View reviewed changes
@alkino
Copy link
Member Author

alkino commented Nov 17, 2020 •
edited
Loading

Please retest

1 similar comment
@alkino
Copy link
Member Author

alkino commented Nov 17, 2020

Please retest

@alkino
Copy link
Member Author

alkino commented Nov 17, 2020

Please retest
for the third time because of NEURON_BRANCH!

@alkino
Copy link
Member Author

alkino commented Nov 17, 2020

Please retest

@alkino alkino requested a review from alexsavulescu November 18, 2020 08:57
@pramodk pramodk merged commit 08c2aeb into master Nov 18, 2020
@pramodk pramodk deleted the clean_code branch November 18, 2020 10:39
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Clean code for BlueBrain/CoreNeuron#250 (BlueBrain/CoreNeuron#421)
181b25e 
* Replace assert(!busy) with nrn_assert
    nrn_assert is compiled too when in release mode.
* Using using instead of typedef

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@08c2aeb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pramodk pramodk pramodk approved these changes

@alexsavulescu alexsavulescu alexsavulescu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alkino @pramodk @alexsavulescu