Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Fix range of permute option to [0, 2]#684

Merged
alkino merged 2 commits intomasterfrom
fix_range
Oct 30, 2021
Merged

Fix range of permute option to [0, 2]#684
alkino merged 2 commits intomasterfrom
fix_range

Conversation

@alkino
Copy link
Copy Markdown
Member

@alkino alkino commented Oct 29, 2021

This fix is quite simple

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #684 (1ff81ea) into master (d2f4d3d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   55.26%   55.26%           
=======================================
  Files         107      107           
  Lines        8716     8716           
=======================================
  Hits         4817     4817           
  Misses       3899     3899           
Impacted Files Coverage Δ
coreneuron/apps/corenrn_parameters.cpp 90.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f4d3d...1ff81ea. Read the comment docs.

@olupton
Copy link
Copy Markdown
Contributor

olupton commented Oct 29, 2021

The docs say:

This produces a range with min and max inclusive.

👍

@alkino alkino merged commit 15d9781 into master Oct 30, 2021
@alkino alkino deleted the fix_range branch October 30, 2021 10:01
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
Co-authored-by: Pramod Kumbhar <pramod.s.kumbhar@gmail.com>

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@15d9781
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants