Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

All interthread events on queue before transfer. #691

Merged
merged 1 commit into from
Nov 18, 2021
Merged

All interthread events on queue before transfer. #691

merged 1 commit into from
Nov 18, 2021

Conversation

@nrnhines
Copy link
Collaborator

@nrnhines nrnhines commented Nov 17, 2021 •
edited by olupton
Loading

Description

Related to neuronsimulator/nrn#1534
This is part of the fix for issue neuronsimulator/nrn#1531

How to test this?
Build the NEURON version for neuronsimulator/nrn#1534

cmake .. -G Ninja -DCMAKE_INSTALL_PREFIX=install -DPYTHON_EXECUTABLE=`pyenv which python` -DNRN_ENABLE_RX3D=OFF -DCMAKE_BUILD_TYPE=Debug -DNRN_ENABLE_CORENEURON=ON -DNRN_ENABLE_TESTS=ON
ninja install
ninja test
# the relevant test is nrn/test/coreneuron/test_datarun.py and can be executed manually by
cd ../test/coreneuron
nrnivmodl -coreneuron mod
python test_datareturn.py

Use certain branches for the SimulationStack CI

CI_BRANCHES:NEURON_BRANCH=hines/nrn2core-tq-bug,

@nrnhines nrnhines requested review from olupton and pramodk November 17, 2021 12:04
@nrnhines nrnhines mentioned this pull request Nov 17, 2021
Merged
@bbpbuildbot
Copy link
Collaborator

bbpbuildbot commented Nov 17, 2021

Logfiles from GitLab pipeline #25196 (:white_check_mark:) have been uploaded here!

Status and direct links:

@olupton
Copy link
Contributor

olupton commented Nov 17, 2021

retest this please Jenkins

olupton
olupton approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(note that the Jenkins-based CI jobs mis-parse the

CI_BRANCHES:NEURON_BRANCH=hines/nrn2core-tq-bug,

clause if there is no trailing ,)

pramodk
pramodk approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit b0f6be0 into master Nov 18, 2021
@pramodk pramodk deleted the hines/core2nrn-tq-bug branch November 18, 2021 01:12
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Nov 2, 2022
@nrnhines
All interthread events on queue before transfer (BlueBrain/CoreNeuron…
c09ab50 
…#691)

See issue described in neuronsimulator/nrnBlueBrain/CoreNeuron#1531

CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b0f6be0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pramodk pramodk pramodk approved these changes

@olupton olupton olupton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nrnhines @bbpbuildbot @olupton @pramodk