This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Conversation
A little bit of cleanup along the way.
Contributor
Author
Collaborator
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
A little bit of other cleanup along the way. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@ca7b498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new solver unit test is failing on newer Red-Hat-based distributions:
This seems to be because that test included the Boost unit test framework in header-only mode but then links against an external copy of the library.
https://www.boost.org/doc/libs/1_79_0/libs/test/doc/html/boost_test/usage_variants.html implies that we need to define different macros for linking against shared/static libraries, and https://cmake.org/cmake/help/latest/module/FindBoost.html makes it look difficult to guarantee static and/or shared, so header-only mode seems like the simple way out.
How to test this?
Build the tests, run them -- you might get an error, or you might need to run them in
valgrindto see it.Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop