Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Fix windows-2022 wheels & MANIFEST.in warnings#388

Merged
mgeplf merged 4 commits intomasterfrom
zisis/fix-manifest
Mar 3, 2022
Merged

Fix windows-2022 wheels & MANIFEST.in warnings#388
mgeplf merged 4 commits intomasterfrom
zisis/fix-manifest

Conversation

@eleftherioszisis
Copy link
Copy Markdown
Contributor

@eleftherioszisis eleftherioszisis commented Mar 1, 2022

Warning example:
warning: manifest_maker: MANIFEST.in, line 6: path '3rdparty/GSL_LITE/cmake/' cannot end with '/'

@eleftherioszisis eleftherioszisis changed the title Fix MANIFEST.in Fix MANIFEST.in warnings Mar 1, 2022
@eleftherioszisis eleftherioszisis requested a review from mgeplf March 1, 2022 14:31
@eleftherioszisis eleftherioszisis removed the request for review from mgeplf March 1, 2022 17:15
@eleftherioszisis eleftherioszisis requested a review from mgeplf March 2, 2022 01:27
@eleftherioszisis eleftherioszisis changed the title Fix MANIFEST.in warnings Fix windows-2022 wheels & MANIFEST.in warnings Mar 3, 2022
@mgeplf
Copy link
Copy Markdown
Contributor

mgeplf commented Mar 3, 2022

For reference, I tested this with a windows 10 install, and all that was required was the vc_redist.x64.exe (the Visual C++ 2015 Redistributable Package 64); so the switch from the v140 -> v141 seems safe.

Thanks!

@mgeplf mgeplf merged commit 86fabba into master Mar 3, 2022
@mgeplf mgeplf deleted the zisis/fix-manifest branch March 3, 2022 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants