Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

CI: Move black, codespell, isort, pycodestyle and pydocstyle from tox to pre-commit#29

Merged
adrien-berchet merged 3 commits into
mainfrom
pre-commit
Apr 7, 2022
Merged

CI: Move black, codespell, isort, pycodestyle and pydocstyle from tox to pre-commit#29
adrien-berchet merged 3 commits into
mainfrom
pre-commit

Conversation

@adrien-berchet
Copy link
Copy Markdown
Member

This commit also formats the files according to the new rules and add commitlint in CI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2022

Codecov Report

Merging #29 (4283317) into main (26e0a98) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          34       34           
  Lines        1859     1859           
  Branches      295      295           
=======================================
  Hits         1807     1807           
  Misses         35       35           
  Partials       17       17           
Flag Coverage Δ
pytest 97.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neurots/morphmath/utils.py 100.00% <ø> (ø)
neurots/extract_input/__init__.py 100.00% <100.00%> (ø)

@adrien-berchet adrien-berchet force-pushed the pre-commit branch 2 times, most recently from 00cea1f to ee8c7de Compare April 6, 2022 22:35
adrien-berchet and others added 3 commits April 7, 2022 09:30
… to pre-commit

This commit also formats the files according to the new rules and add commitlint in CI.
Copy link
Copy Markdown
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if we are going to love or hate pre-commit :D

@adrien-berchet
Copy link
Copy Markdown
Member Author

Hehe ;-P
Remember that you have to pip install it locally and call pre-commit install for optimal use. If you don't it will just behave as usual: the code is only checked in the CI.

@adrien-berchet adrien-berchet merged commit ce95cd5 into main Apr 7, 2022
@adrien-berchet adrien-berchet deleted the pre-commit branch April 7, 2022 12:55
@adrien-berchet
Copy link
Copy Markdown
Member Author

Ah and if you think the checks are too strict (I added a few new ones 😇), we can discuss it :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants