This repository was archived by the owner on Feb 26, 2025. It is now read-only.
update targeting/randomness to paper values#30
Merged
Conversation
Author
|
I thought more test would have depended on that, but apparently no! |
adrien-berchet
approved these changes
Mar 22, 2022
Member
adrien-berchet
left a comment
adrien-berchet
left a comment
There was a problem hiding this comment.
The previous values are no more relevant? Where did they come from?
Author
|
they are outdated, these ones have been calibrated for synthesis paper. They are not used as the tmd_parameter.json is rarely made from this function, but it's better to have working values here, in case somebody wants to try this code without our home made .json files. |
Member
|
Ok I see, thanks |
Author
|
Sorry about the email spam, I was trying to see if I could merge with only one approval, but I can't. If it's ok with you @lidakanari , I'll just need your +2 to merge this one, thanks! |
lidakanari
approved these changes
Apr 7, 2022
Collaborator
lidakanari
left a comment
lidakanari
left a comment
There was a problem hiding this comment.
Sorry, forgot to approve this one. You can merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.