-
Notifications
You must be signed in to change notification settings - Fork 15
Improve command line parsing, adapt to Eyescale/CMake#533 #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| # -*- mode: cmake -*- | ||
| # CMake/common https://github.com/Eyescale/CMake.git 3d5d284 | ||
| # CMake/common https://github.com/Eyescale/CMake.git 40e030e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # -*- mode: cmake -*- | ||
| git_subproject(ZeroEQ https://github.com/HBPVIS/ZeroEQ.git 9b7ca61) | ||
| git_subproject(Deflect https://github.com/BlueBrain/Deflect.git 76526f0) | ||
| git_subproject(TUIO https://github.com/BlueBrain/TUIO.git fdf5cf7) | ||
| git_subproject(ZeroEQ https://github.com/HBPVIS/ZeroEQ.git 505caf8) | ||
| git_subproject(Deflect https://github.com/BlueBrain/Deflect.git 7ebb0a5) | ||
| git_subproject(TUIO https://github.com/BlueBrain/TUIO.git 67a65ad) | ||
| git_subproject(VirtualKeyboard https://github.com/rdumusc/QtFreeVirtualKeyboard.git b2f79e3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,47 @@ | ||
| # Copyright (c) 2013-2016, EPFL/Blue Brain Project | ||
| # Copyright (c) 2013-2017, EPFL/Blue Brain Project | ||
| # Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
|
|
||
| include(CommonHelp) | ||
|
|
||
| include_directories(${PROJECT_SOURCE_DIR}/tide/core) | ||
|
|
||
| add_subdirectory(TideForker) | ||
| add_subdirectory(TideMaster) | ||
| add_subdirectory(TideWall) | ||
| add_subdirectory(Launcher) | ||
| add_subdirectory(Whiteboard) | ||
|
|
||
| set(_tide_in ${CMAKE_CURRENT_SOURCE_DIR}/tide) | ||
| set(_tide_out ${PROJECT_BINARY_DIR}/bin/tide) | ||
| add_custom_command( | ||
| DEPENDS ${_tide_in} | ||
| OUTPUT ${_tide_out} | ||
| POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy ${_tide_in} ${_tide_out} | ||
| ) | ||
| add_custom_target(tide ALL DEPENDS ${_tide_out} tideForker tideMaster tideWall | ||
| tideLauncher tideWhiteboard | ||
| ) | ||
| add_dependencies(${PROJECT_NAME}-all tide) | ||
|
|
||
| if(TARGET Qt5::WebKitWidgets) | ||
| add_subdirectory(LocalStreamer) | ||
| add_subdirectory(LocalStreamer) | ||
| add_dependencies(tide tideLocalstreamer) | ||
| endif() | ||
| if(TARGET Qt5::WebEngine) | ||
| add_subdirectory(Webbrowser) | ||
| add_dependencies(tide tideWebbrowser) | ||
| endif() | ||
|
|
||
| install(PROGRAMS pyramidmaker tide DESTINATION bin COMPONENT apps) | ||
|
|
||
| # Copy the startup script and default config to the bin folder to be able to | ||
| # launch after building without requiring an install folder and 'make install' | ||
| file(COPY pyramidmaker tide DESTINATION ${CMAKE_BINARY_DIR}/bin) | ||
| file(COPY ${PROJECT_SOURCE_DIR}/examples/configuration_1x3.xml | ||
| DESTINATION ${CMAKE_BINARY_DIR}/share/Tide/examples | ||
| file( | ||
| COPY ${PROJECT_SOURCE_DIR}/examples/configuration_1x3.xml | ||
| DESTINATION ${PROJECT_BINARY_DIR}/share/Tide/examples | ||
| ) | ||
|
|
||
| file(COPY pyramidmaker DESTINATION ${PROJECT_BINARY_DIR}/bin) | ||
| install(PROGRAMS pyramidmaker tide DESTINATION bin COMPONENT apps) | ||
|
|
||
| # Generate application help pages for doxygen | ||
| common_help(tide LOCATION ${_tide_out}) | ||
| common_help(pyramidmaker LOCATION ${PROJECT_BINARY_DIR}/bin/pyramidmaker) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
|
|
||
| # Copyright (c) 2013-2015, EPFL/Blue Brain Project | ||
| # Copyright (c) 2013-2017, EPFL/Blue Brain Project | ||
| # Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
|
|
||
| include_directories(${PROJECT_SOURCE_DIR}/tide/master) | ||
|
|
||
| set(LOCALSTREAMER_HEADERS | ||
| set(TIDELOCALSTREAMER_HEADERS | ||
| Application.h | ||
| ) | ||
|
|
||
| set(LOCALSTREAMER_SOURCES | ||
| main.cpp | ||
| set(TIDELOCALSTREAMER_SOURCES | ||
| Application.cpp | ||
| main.cpp | ||
| ) | ||
|
|
||
| set(LOCALSTREAMER_LINK_LIBRARIES TideMaster Deflect) | ||
| set(TIDELOCALSTREAMER_LINK_LIBRARIES TideMaster Deflect) | ||
|
|
||
| common_application(localstreamer) | ||
| common_application(tideLocalstreamer NOHELP) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| # Copyright (c) 2013-2016, EPFL/Blue Brain Project | ||
| # Copyright (c) 2013-2017, EPFL/Blue Brain Project | ||
| # Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
|
|
||
| include_directories(${PROJECT_SOURCE_DIR}/tide/master) | ||
|
|
||
| set(TIDEFORKER_SOURCES main.cpp) | ||
| set(TIDEFORKER_LINK_LIBRARIES TideMaster) | ||
| common_application(tideForker) | ||
| common_application(tideForker NOHELP) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| # Copyright (c) 2013-2016, EPFL/Blue Brain Project | ||
| # Copyright (c) 2013-2017, EPFL/Blue Brain Project | ||
| # Raphael Dumusc <raphael.dumusc@epfl.ch> | ||
|
|
||
| include_directories(${PROJECT_SOURCE_DIR}/tide/master) | ||
|
|
||
| set(TIDEMASTER_SOURCES main.cpp) | ||
| set(TIDEMASTER_LINK_LIBRARIES TideMaster) | ||
| common_application(tideMaster) | ||
| common_application(tideMaster NOHELP) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not configure_file(@only)? This way it should run only if _tide_in has changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I had to investigate more to understand:
However, my code was missing "DEPENDS ${_tide_in}" in add_custom_command(), so it did not copy the file again if _tide_in was changed. Now everything works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good then.