Implement REST API based on ZeroEQ [DISCL-355]#12
Merged
rdumusc merged 2 commits intoBlueBrain:masterfrom May 4, 2016
Merged
Conversation
| */ | ||
| explicit RestCommand( const std::string& name ); | ||
|
|
||
| /** @retrun the name of the command passed in the constructor. */ |
Contributor
|
+1 when the build gets green |
Author
|
Thanks, build was red due to old version of Servus (without Serializable) pulled in by Deflect. I swapped ZeroEQ and Deflect in .gitsubprojects as a fix. |
rdumusc
force-pushed
the
rest
branch
3 times, most recently
from
36718c4 to
f2289c4
Compare
| common_find_package(Qt5Xml REQUIRED) | ||
| common_find_package(ZeroEQ) | ||
|
|
||
| if(ZeroEQ_FOUND) |
Author
There was a problem hiding this comment.
If you prefer but it makes no difference :-)
Contributor
There was a problem hiding this comment.
I have no preference, but it's my understanding that TARGETs are the cmake 3 way, and Find/FOUND is not advised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.