Skip to content

Fix crash with malformed encoded pixel streams, e.g. JPEG quality > 100#174

Merged
dnachbaur merged 1 commit intoBlueBrain:1.4-devfrom
dnachbaur:1.4-dev
Aug 8, 2017
Merged

Fix crash with malformed encoded pixel streams, e.g. JPEG quality > 100#174
dnachbaur merged 1 commit intoBlueBrain:1.4-devfrom
dnachbaur:1.4-dev

Conversation

@dnachbaur
Copy link
Copy Markdown
Contributor

No description provided.

@dnachbaur dnachbaur requested a review from rdumusc August 7, 2017 15:28
Comment thread tide/wall/DataProvider.h
template <typename DataSources>
void _updateTiles(DataSources& dataSources);

template <typename DataSource, typename URIType>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this typename URIType is needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dataSources can have QString (for Pixelstreams) and QUuid (all the others) as an identifier.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dnachbaur dnachbaur merged commit 33072c7 into BlueBrain:1.4-dev Aug 8, 2017
rdumusc pushed a commit to rdumusc/Tide that referenced this pull request Sep 5, 2017
rdumusc pushed a commit to rdumusc/Tide that referenced this pull request Sep 5, 2017
rdumusc pushed a commit to rdumusc/Tide that referenced this pull request Sep 5, 2017
rdumusc pushed a commit to rdumusc/Tide that referenced this pull request Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants