Adding sticky bezels and window maximize on snap to web interface#195
Merged
rdumusc merged 4 commits intoBlueBrain:masterfrom Oct 17, 2017
Merged
Adding sticky bezels and window maximize on snap to web interface#195rdumusc merged 4 commits intoBlueBrain:masterfrom
rdumusc merged 4 commits intoBlueBrain:masterfrom
Conversation
ppodhajski
force-pushed
the
feature/stickybezel
branch
2 times, most recently
from
6ee4689 to
d8de951
Compare
ppodhajski
force-pushed
the
feature/stickybezel
branch
from
d8de951 to
2227804
Compare
rdumusc
reviewed
Oct 9, 2017
rdumusc
left a comment
rdumusc
left a comment
There was a problem hiding this comment.
Looks good to me, just a few cleanups to do!
| } | ||
|
|
||
| function isBezelVisible(){ | ||
| return ($('.screen').is(':visible')); |
There was a problem hiding this comment.
shouldn't the class be called '.bezel' then ?
| function isAnyWindowDragged() | ||
| { | ||
| return ($(".ui-draggable-dragging").length == 1 ); | ||
|
|
| } | ||
| } | ||
| $(".bezel").css("grid-column-gap", bezelWidth).css("grid-row-gap", bezelHeight).hide(); | ||
| $(".screen").css("outline-width", bezelWidth).css("outline-height", bezelHeight)//.hide(); |
|
|
||
| for (var j = 0; j < totalDisplaysPerScreen; j++) { | ||
| var bezels = [{name: 'N', type: 'horizontal'},{name: 'S', type: 'horizontal'}, | ||
| {name: 'E', type: 'vertical'},{name: 'W', type: 'vertical'},]; |
| tile.width = ui.size.width | ||
| } | ||
| var params = {"id": tile.uuid, "w": tile.width, "h": tile.height, "centered": false}; | ||
| var params = { "id": tile.uuid, "w": tile.width, "h": tile.height, "centered": false }; |
There was a problem hiding this comment.
why changed? style not consistent with the lines above...
| var wallMargin = (window.innerWidth - (wallWidth * zoomScale)) / 2; | ||
| var wall = $("#wall"); | ||
| wall.css({transform: 'scale(' + zoomScale + ')'}); | ||
| wall.css({ transform: 'scale(' + zoomScale + ')' }); |
There was a problem hiding this comment.
same here. If this is the new style, then please use it consistently (cf. lines 992 - 1008)
| $div.css("top", centerV); | ||
| $div.css("left", left); | ||
| } | ||
| // Allign a window exceeding a screen to the left |
|
|
||
| * [195](https://github.com/BlueBrain/Tide/pull/195): | ||
| New features in html interface: | ||
| - Dragged window is snapped to a bezel. |
| * [195](https://github.com/BlueBrain/Tide/pull/195): | ||
| New features in html interface: | ||
| - Dragged window is snapped to a bezel. | ||
| - Dragged window will get maximized to the screen size when hovering a bezel. |
ppodhajski
force-pushed
the
feature/stickybezel
branch
from
1671cd3 to
26d3fe4
Compare
added 2 commits
October 17, 2017 11:20
rdumusc
approved these changes
Oct 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.